[PATCH] D99066: [AutoUpgrade] Take unnamed types into account.

[Jeroen Dobbelaere via Phabricator via llvm-commits]

jeroen.dobbelaere added a comment.

In D99066#2641561 <https://reviews.llvm.org/D99066#2641561>, @fhahn wrote:

> How many places would need to be updated? It sounds like there's no nice solution (automatically catch cases that really need the module), but it also seems brittle to have `Intrinsic::getName` crash in various places because of missing `Module` arguments.

It's not too much. We better then always require the Module parameter whenever types are provided.

[..]

>> Note: There might also be an issue with `LLVMIntrinsicCopyOverloadedName`, which does not have a `Module` parameter. As long as no unnamed types are used, that interface is fine, but it does not support unnamed types.
>
> Ok it sounds like we also need a fix to the C api?

If we want to support the unnamed types, yes. Can we just require/add an extra Module argument ? Are there any rules for backwards compatibility for the C api ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99066/new/

https://reviews.llvm.org/D99066