[PATCH] D95339: [RFC][test] Adapt debug-info lit framework for more general purposes - part 1

Mon Mar 22 01:29:30 PDT 2021

jhenderson added a comment.

In D95339#2638619 <https://reviews.llvm.org/D95339#2638619>, @aprantl wrote:

>> Perhaps Apple folks who implemented the original (@aprantl and @JDevlieghere I believe) can weigh in on their intended (& realized/actual) use cases for this functionality - though I agree that probably an explicit opt in to "I want to test with whatever binaries are in my PATH rather than just-built tools in this checkout" would be desirable here.
>
> This is more incidental than intentional behavior. The debuginfo-tests originally tested that the "system" /usr/bin/gdb would could debug clang-generated code. At some point I generalized the testsuite to also support LLDB, and kept the use-the-system-debugger behavior. In a monorepo world it makes much more sense to make this behavior configurable, but I would appreciate an option to test against an LLDB that is installed somewhere in the system and not just the latest version from the monorepo, so we can test some basic level backwards compatibility.

Okay, all sounds reasonable to me. I think there's a more general problem that the lit tests can use tools in the PATH, outside the build directory, if the tool hasn't been built (this is based on reading the lit source code - I need to confirm this in other test directories). I think we can resolve all of this with a new CMake variable, something like LLVM_USE_INSTALLED_TOOLS_FOR_TESTS (other name suggestions welcome). I'll take a look at this at some point in the coming days and post something on the mailing list to get more people's attention.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95339/new/

https://reviews.llvm.org/D95339