[PATCH] D99075: [ARM] Handle debug instrs in ARM Low Overhead Loop pass

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMLowOverheadLoops.cpp:1468
+    if (PIdx < 1) {
       llvm_unreachable("trying to unpredicate a non-predicated instruction");
+      return;
----------------
This looks like it should be an assert.


================
Comment at: llvm/lib/Target/ARM/ARMLowOverheadLoops.cpp:1518
         MachineInstr *Divergent = VPTState::getDivergent(Block);
         auto DivergentNext = ++MachineBasicBlock::iterator(Divergent);
         bool DivergentNextIsPredicated =
----------------
I think this might have to handle debug better. Can we try and make sure that DivergentNext is not a debug instruction.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99075/new/

https://reviews.llvm.org/D99075