[PATCH] D99068: [RISCV][WIP][RFC] Fix stack slot for argument type sizes not a multiple of 64 bits (Bug 49500)

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 22 04:50:53 PDT 2021


frasercrmck added a comment.

In D99068#2641065 <https://reviews.llvm.org/D99068#2641065>, @luismarques wrote:

> At first glance it looks like it does.

Excellent!

My fix was more direct: I went over `ArgValue` and all of the `SDValue PartValue = OutVals[i + 1];` as in the loop later in this block, and summed up all of the required `getStoreSize`s of their VTs, and took the maximum required alignment of each. Then created a stack temporary of that summed size and max alignment. I wasn't sufficiently happy with it and since I didn't get much indication that this was an urgent fix I didn't put it up for discussion - sorry about that. I can share my patch with you if you're interested.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99068/new/

https://reviews.llvm.org/D99068



More information about the llvm-commits mailing list