[PATCH] D98581: [llvm-jitlink] Add diagnostic output and port executor to getaddrinfo(3) as well

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 22 03:37:21 PDT 2021


thakis added inline comments.


================
Comment at: llvm/tools/llvm-jitlink/llvm-jitlink.cpp:680
+static Expected<int> connectTCPSocket(std::string Host, std::string PortStr) {
   addrinfo *AI;
   addrinfo Hints{};
----------------
No, I think it's this one (at least partially). This here used to be behind LLVM_ON_UNIX but now it isn't. Probably just needs to go back behind that check.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98581/new/

https://reviews.llvm.org/D98581



More information about the llvm-commits mailing list