[PATCH] D99064: [RS4GC] Cleanup meetBDVState. NFC.
Serguei Katkov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 22 03:18:22 PDT 2021
skatkov created this revision.
skatkov added reviewers: reames, dantrushin.
Herald added a subscriber: hiraditya.
skatkov requested review of this revision.
Herald added a project: LLVM.
meetBDVState looks pretty difficult to read and follow.
This is purely NFC but doing several things:
1. Combine meet and meetBDVState
2. move the function under member of BDVState
3. Make BDVState be a mutable object.
4. Convert switch to sequence of ifs
5. Adds comments.
The patch is published to get a feedback whether this change simplifies the reading of the method.
If it is not, I'm fine to abandon it.
https://reviews.llvm.org/D99064
Files:
llvm/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99064.332229.patch
Type: text/x-patch
Size: 3524 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210322/8351d865/attachment.bin>
More information about the llvm-commits
mailing list