[PATCH] D99055: [llvm-objcopy][NFC] remove processing of ELF specific options from common CopyConfig structure.

Mon Mar 22 02:31:15 PDT 2021

avl added a comment.

> Could you do this in a separate patch upfront, please? As things stand, this patch is not NFC, because of this...! I have some concerns about the specific nature of the non-NFC part, which I'd like to comment on separately.

It would be a bit artificial... Since the change on how error message is displayed happens because option processing was moved form common part into the specific part. i.e. it could not be separated from this change. But I might be done by adding extra code:

  Expected<elf::ELFCopyConfig> ELFConfig = elf::parseConfig(*this);
  if (!ELFConfig)
    return createFileError(Config.InputFilename, ELFConfig.takeError());

Would create a separate review.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99055/new/

https://reviews.llvm.org/D99055