[PATCH] D98934: [SVE] Add instruction cost for fptrunc in loops
David Sherwood via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 22 02:28:11 PDT 2021
david-arm added inline comments.
================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:470
+
+ // From nxvmf32 to nxmf64
+ { ISD::FP_ROUND, MVT::nxv2f32, MVT::nxv2f64, 1 },
----------------
nit: I think this should be:
// From nxvmf32 to nxvmf64
================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:473
+ { ISD::FP_ROUND, MVT::nxv4f32, MVT::nxv4f64, 1 },
+ { ISD::FP_ROUND, MVT::nxv8f32, MVT::nxv8f64, 1 },
};
----------------
Are we missing other types/combinations here too? For example:
{ ISD::FP_ROUND, MVT::nxv2f16, MVT::nxv2f64, 1 },
and
{ ISD::FP_ROUND, MVT::nxv4f16, MVT::nxv4f32, 1 },
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98934/new/
https://reviews.llvm.org/D98934
More information about the llvm-commits
mailing list