[PATCH] D98003: [obj2yaml] Implement parsing sections and auxiliary entries of XCOFF.

[Qiu Chaofan via Phabricator via llvm-commits]

qiucf added inline comments.


================
Comment at: llvm/include/llvm/ObjectYAML/XCOFFYAML.h:59
+struct CsectAuxEnt32 {
+  uint32_t SectionOrLength;
+  uint32_t ParameterHashIndex;
----------------
Better to add brief comment like `length or symbol table index, depending on symbol type.`? Like D68650.


================
Comment at: llvm/test/tools/obj2yaml/XCOFF/aix.yaml:74
 # CHECK: Symbols:
-# CHECK-NEXT:   - Name:      .file
-# CHECK-NEXT:     Value:     0x0
-# CHECK-NEXT:     Section: N_DEBUG
-# CHECK-NEXT:     Type:      0x3
+# CHECK-NEXT:   - Name:            .file
+# CHECK-NEXT:     Value:           0x0
----------------
As I see this test is not auto-generated? So can we reduce the indents to make the diff minimal?


================
Comment at: llvm/tools/obj2yaml/xcoff2yaml.cpp:32
 
 std::error_code XCOFFDumper::dump() {
   dumpHeader();
----------------
Why not change return type to `Error`?


================
Comment at: llvm/tools/obj2yaml/xcoff2yaml.cpp:152
+      }
+      break;
+    case XCOFF::C_EXT:
----------------
Put `break` inside brace.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98003/new/

https://reviews.llvm.org/D98003