[PATCH] D99055: [llvm-objcopy][NFC] remove processing of ELF specific options from common CopyConfig structure.

Alexey Lapshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 21 23:40:51 PDT 2021


avl created this revision.
avl added reviewers: jhenderson, MaskRay, dblaikie, alexshap, rupprecht.
Herald added subscribers: abrachet, mgorny, emaste.
avl requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This patch moves processing of ELF specific options from common CopyConfig.h
into ELF specific ELFObjcopy.cpp. It allows to separate ELF specific processing
from common code.

It also makes format of error mesages for --add-symbol option
matching with format of error mesages for other options.

old format:
error: bad format for --add-symbol, missing '=' after 'test'

new format:
error: 'file name': bad format for --add-symbol, missing '=' after 'test'


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D99055

Files:
  llvm/test/tools/llvm-objcopy/ELF/add-symbol.test
  llvm/tools/llvm-objcopy/CMakeLists.txt
  llvm/tools/llvm-objcopy/CopyConfig.h
  llvm/tools/llvm-objcopy/ELF/ELFConfig.cpp
  llvm/tools/llvm-objcopy/ELF/ELFConfig.h
  llvm/tools/llvm-objcopy/ELF/ELFObjcopy.cpp
  llvm/tools/llvm-objcopy/llvm-objcopy.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99055.332205.patch
Type: text/x-patch
Size: 18003 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210322/2febddbc/attachment.bin>


More information about the llvm-commits mailing list