[PATCH] D98921: [CSSPGO][llvm-profgen] Use profile summary based threshold for context trimming and merging

[Lei Wang via Phabricator via llvm-commits]

wlei added inline comments.


================
Comment at: llvm/test/tools/llvm-profgen/merge-cold-profile.test:54
+; CHECK-UNMERGED-NEXT: !CFGChecksum: 72617220756
+
 
----------------
How about we add:
```
; CHECK-UNMERGED-NOT: [fa]
; CHECK-UNMERGED-NOT: [fb]
```
to make sure the merging not happen.


================
Comment at: llvm/tools/llvm-profgen/ProfileGenerator.cpp:239
+  // context profile merging/trimming.
+  computeSummaryAndThreshold();
 }
----------------
There is two places to call this function: for probe and non-probe.
How about to move this to `CSProfileGenerator::write(...)` so that we only keep one call for this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98921/new/

https://reviews.llvm.org/D98921