[PATCH] D99022: [IR] Mark assume/annotation as InaccessibleMemOnly

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LGTM,



================
Comment at: llvm/lib/Analysis/BasicAliasAnalysis.cpp:950
-  // that proper control dependencies are maintained but they never mods any
-  // particular memory location.
   //
----------------
nikic wrote:
> jdoerfert wrote:
> > This and the snipped below are still "needed". Inaccessiblemem is not as powerful as this logic.
> Why is this still needed (we should add a test if so)? MemoryLocation always refers to an accessible location, so I believe we'll always return NoModRef between InaccessibleMemOnly and MemoryLocation.
> 
> For the code below I could see that it may still have an effect because with InaccessibleMemOnly, two assumes would still ModRef each other, but I'm not sure if there's any way for that to be practically relevant.
Good point. I didn't realize the "other operand" is a MemoryLocation. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99022/new/

https://reviews.llvm.org/D99022