[PATCH] D96021: [LoopVectorize] NFC: Move UserVF feasibility checks to separate function.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

In D96021#2622221 <https://reviews.llvm.org/D96021#2622221>, @sdesmalen wrote:

> Hi @fhahn,
>
>> [..]
>> In the end, the code is not vastly different and I think there are no absolute answers here. I hope the above explains the direction from which I am looking at this a bit better than I did initially.
>
> Yes, thanks for this, that was helpful! My original reason for splitting the patch series out like this was to make some trivial NFC "move code around" changes that were relatively simple to review, before making functional changes for scalable vectors. After seeing more clearly what you mean, I agree with you that the code becomes a bit more readable by being a bit more rigorous in the refactoring, and it also simplified the follow-up patches a bit.
>
> Long story short, I have updated my patch series to align it more with the approach that you outlined in D96997 <https://reviews.llvm.org/D96997>. My new patch is in D98509 <https://reviews.llvm.org/D98509> and I'll abandon this series.

Thanks! I would have been happy to update my patch, but it's great you put up an update patch. I'll take a closer look early in the coming week!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96021/new/

https://reviews.llvm.org/D96021