[PATCH] D98559: [lld-macho] Implement -dependency_info (partially - more opcodes needed)

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 21 10:53:08 PDT 2021


int3 added inline comments.


================
Comment at: lld/MachO/Driver.cpp:825
+    StringRef path = arg->getValue();
+    if ((fs::exists(path) && !fs::can_write(path))) {
+      warn("Ignoring dependency_info option since specified path is not "
----------------
extra parens


================
Comment at: lld/MachO/Driver.cpp:826
+    if ((fs::exists(path) && !fs::can_write(path))) {
+      warn("Ignoring dependency_info option since specified path is not "
+           "writeable.");
----------------
our other option-related messages include the dash, so it would be nice to use that here too :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98559/new/

https://reviews.llvm.org/D98559



More information about the llvm-commits mailing list