[PATCH] D98391: [InstSimplify] Propagate AllowRefinement info from SimplifyWithOpReplaced

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 20 14:04:27 PDT 2021


nikic added a comment.

I've put up D99027 <https://reviews.llvm.org/D99027> as a possible alternative, though I'm not really sure yet which approach is best here. My premise is that for the AllowRefinement=false case the main thing we care about are the constant folding cases, plus a small set of additional folds. This avoids infecting the rest of InstSimplify with another parameter, and we can't run into issues when we forgot the check the flag somewhere. On the other hand, this approach may lose optimization power.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98391/new/

https://reviews.llvm.org/D98391



More information about the llvm-commits mailing list