[PATCH] D95339: [RFC][test] Adapt debug-info lit framework for more general purposes - part 1

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 19 10:28:58 PDT 2021


dblaikie added a subscriber: JDevlieghere.
dblaikie added a comment.

In D95339#2635435 <https://reviews.llvm.org/D95339#2635435>, @mehdi_amini wrote:

>> Do we need something more than that?
>
> Yes: that may be how the debuginfo-tests was setup, but that seems like a no-go to me for generalizing this into a "cross-projects" that intends to serve the monorepo, for the reasons I mentioned above. I may be interested in some cross-project test in the future but unlikely to want to test lldb. Yet lldb is in `/usr/bin/` on my Mac and this isn't a good "default" to use this for running the tests here IMO, especially when I don't intend this (and I obviously can't remove `/usr/bin/` from my path without unintended consequences)

Perhaps Apple folks who implemented the original (@aprantl and @JDevlieghere I believe) can weigh in on their intended (& realized/actual) use cases for this functionality - though I agree that probably an explicit opt in to "I want to test with whatever binaries are in my PATH rather than just-built tools in this checkout" would be desirable here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95339/new/

https://reviews.llvm.org/D95339



More information about the llvm-commits mailing list