[PATCH] D98395: [lld-macho] Avoid requiring shell in tests

Sat Mar 20 07:40:29 PDT 2021

thakis added a comment.

Thanks for the fix! re `touch`: LLVM requires a whole bunch of unixy utilities for running tests even on Windows. http://commondatastorage.googleapis.com/chromium-browser-clang/tools/gnuwin-14.zip contains the ones that are currently needed. `touch` is among them, so that test should Just Work on Windows – many other tests use `touch` too.

The other two tests sound mostly fine as-is: The ANSI thing sounds like it might need shell for now (very new versions of windows apparently ship with the new win terminal that has ansi support, but we can't rely on this). For the symlink thing, maybe `UNSUPPORTED: system-windows` is clearer than `REQUIRES: shell` if it's for symlinks? But those are both nits.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98395/new/

https://reviews.llvm.org/D98395