[PATCH] D98875: [HWASan] Use page aliasing on x86_64.

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 19 18:12:28 PDT 2021


eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: compiler-rt/lib/hwasan/hwasan_dynamic_shadow.cpp:123
+  constexpr uptr kNumAliases = 1ULL << kTagBits;
+  constexpr uptr kRingBufferSize = 1ULL << kShadowBaseAlignment;
+  return MapDynamicShadowAndAliases(shadow_size_bytes, kAliasSize, kNumAliases,
----------------
this seems kind of arbitrary, why not RingBufferSize()?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98875/new/

https://reviews.llvm.org/D98875



More information about the llvm-commits mailing list