[PATCH] D98063: [flang][fir] Add the pre-code gen rewrite pass and codegen ops.

Fri Mar 19 17:41:08 PDT 2021

mehdi_amini added a comment.

In D98063#2638971 <https://reviews.llvm.org/D98063#2638971>, @svedanayagam wrote:

> Re the comment on losing on parallelism, the uploaded code is functionally correct and complete.

This is true, there are still a bunch of comment I have that are still undressed even the parallelism aside: i.e. refactoring DCE and not duplicating the registration function when it isn't needed or not justified.

> We (or the community at large) can certainly make this execute in parallel once the up-streaming is done.  Fast execution and maintainability are in everyone’s interests, including ours, and we will be motivated to update the code after we've up streamed code gen and its tests.
>
> We would like to upstream this part of the patch with an understanding that it will be fixed at a later date.

This does not answer my previous question: are you OK with me sending a patch to fix the parallelism there immediately after this patch lands?
I am under the impression right now that this is not possible because it would break some downstream tests in some ways that are unclear to me at the moment.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98063/new/

https://reviews.llvm.org/D98063