[PATCH] D98888: [AMDGPU] SIOptimizeExecMaskingPreRA should check constant bus constraint when folds EXEC copy
Alexander via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 19 15:07:57 PDT 2021
alex-t added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/SIOptimizeExecMaskingPreRA.cpp:424
+ if (SingleExecUser->getParent() == I->getParent() &&
+ !SingleExecUser->getOperand(Idx).isImplicit() &&
+ TII->isOperandLegal(*SingleExecUser, Idx, &I->getOperand(1))) {
----------------
rampitec wrote:
> It is OK for exec operand to be implicit, but you do not need to check for legality in this case.
The EXEC register may be an implicit operand but the "Idx" is the index of the Sreg64 register that holds the EXEC copy.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98888/new/
https://reviews.llvm.org/D98888
More information about the llvm-commits
mailing list