[llvm] a1ab562 - Revert "[NewPM] Verify LoopAnalysisResults after a loop pass"

[Arthur Eubanks via llvm-commits]

Author: Arthur Eubanks
Date: 2021-03-19T14:31:08-07:00
New Revision: a1ab5627f012aee9d204cea67d79dc1f172b46f8

URL: https://github.com/llvm/llvm-project/commit/a1ab5627f012aee9d204cea67d79dc1f172b46f8
DIFF: https://github.com/llvm/llvm-project/commit/a1ab5627f012aee9d204cea67d79dc1f172b46f8.diff

LOG: Revert "[NewPM] Verify LoopAnalysisResults after a loop pass"

This reverts commit 94c269baf58330a5e303a4f86f64681f2f7a858b.

Still causes too large of compile time regression in normal debug
builds. Will put under expensive checks instead.

Added: 
    

Modified: 
    llvm/lib/Transforms/Scalar/LoopPassManager.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Transforms/Scalar/LoopPassManager.cpp b/llvm/lib/Transforms/Scalar/LoopPassManager.cpp
index bea938a7a9cc..60a9602096bb 100644
--- a/llvm/lib/Transforms/Scalar/LoopPassManager.cpp
+++ b/llvm/lib/Transforms/Scalar/LoopPassManager.cpp
@@ -14,7 +14,6 @@
 #include "llvm/Analysis/MemorySSA.h"
 #include "llvm/Analysis/ScalarEvolutionAliasAnalysis.h"
 #include "llvm/Analysis/TargetLibraryInfo.h"
-#include "llvm/Support/Debug.h"
 #include "llvm/Support/TimeProfiler.h"
 
 using namespace llvm;
@@ -292,15 +291,8 @@ PreservedAnalyses FunctionToLoopPassAdaptor::run(Function &F,
     else
       PI.runAfterPass<Loop>(*Pass, *L, PassPA);
 
-#ifndef NDEBUG
-    // LoopAnalysisResults should always be valid.
-    // Note that we don't LAR.SE.verify() because that can change observed SE
-    // queries. See PR44815.
-    LAR.DT.verify();
-    LAR.LI.verify(LAR.DT);
-    if (LAR.MSSA && VerifyMemorySSA)
-      LAR.MSSA->verifyMemorySSA();
-#endif
+    // FIXME: We should verify the set of analyses relevant to Loop passes
+    // are preserved.
 
     // If the loop hasn't been deleted, we need to handle invalidation here.
     if (!Updater.skipCurrentLoop())