[PATCH] D98901: [AIX] Update rpath for BUILD_SHARED_LIBS

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 19 13:39:45 PDT 2021


hubert.reinterpretcast added inline comments.


================
Comment at: llvm/cmake/modules/AddLLVM.cmake:2113
+    # FIXME: update this when there is better solution.
+    set(_install_rpath "${LLVM_LIBRARY_OUTPUT_INTDIR}" "${CMAKE_INSTALL_PREFIX}/lib${LLVM_LIBDIR_SUFFIX}")
   elseif(UNIX)
----------------
jsji wrote:
> hubert.reinterpretcast wrote:
> > How should `LLVM_LIBRARY_DIR` (used with `extra_libdir`) be incorporated (or not) here?
> I can include `extra_libdir` if we want to support `LLVM_INSTALL_PREFIX` as well. 
Thanks. I think adding `extra_libdir` makes sense to reduce unnecessary differences.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98901/new/

https://reviews.llvm.org/D98901



More information about the llvm-commits mailing list