[PATCH] D98901: [AIX] Update rpath for BUILD_SHARED_LIBS

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/cmake/modules/AddLLVM.cmake:2113
+    # FIXME: update this when there is better solution.
+    set(_install_rpath "${LLVM_LIBRARY_OUTPUT_INTDIR}" "${CMAKE_INSTALL_PREFIX}/lib${LLVM_LIBDIR_SUFFIX}")
   elseif(UNIX)
----------------
How should `LLVM_LIBRARY_DIR` (used with `extra_libdir`) be incorporated (or not) here?


================
Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:218
+    # FIXME: Remove this warning if this rpath is no longer hardcoded.
+    message(WARNING "Build and install environment path info may be exposed, binaries also unrelocatable.")
+  endif()
----------------
Minor wording/grammar nits.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98901/new/

https://reviews.llvm.org/D98901