[PATCH] D98975: [NFC][ValueTypes] Align code by column

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/ValueTypes.td:165
 def nxv16i32: ValueType<512, 132>; // n x 16 x i32 vector value
 def nxv32i32: ValueType<1024,133>; // n x 32 x i32 vector value
 
----------------
Should this after a space after the comma?


================
Comment at: llvm/include/llvm/CodeGen/ValueTypes.td:199
 def funcref : ValueType<0,   163>; // WebAssembly's funcref type
 def externref : ValueType<0, 164>; // WebAssembly's externref type
 def x86amx : ValueType<8192, 165>; // X86 AMX value
----------------
Maybe align all the colons in this group with the colon from externref?


================
Comment at: llvm/include/llvm/CodeGen/ValueTypes.td:211
 // Pseudo valuetype to represent "vector of any size"
-def vAny   : ValueType<0  , 251>;
+def vAny   : ValueType<0,   251>;
 
----------------
Should we be aligning the : and the start of ValueType rather than the 251?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98975/new/

https://reviews.llvm.org/D98975