[PATCH] D98884: [IR] Add opt-in parameter to hasAddressTaken() to ignore bitcasts callee in callbase instruction

Fri Mar 19 11:57:56 PDT 2021

madhur13490 marked 2 inline comments as done.
madhur13490 added a comment.

In D98884#2635600 <https://reviews.llvm.org/D98884#2635600>, @rampitec wrote:

> This test also does not really work until you add true argument to the call graph builder.

I am not sure if I follow. I don't intend do any changes (at least for current patch) in the way call graph builder works because that will break a lot of things. (I tried adding "true" for call graph builder and call changed which was obvious.) FileCheck commands are just inline with what this opt with this patch would emit. Referring to https://reviews.llvm.org/D96087, would those test cases too won't work?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98884/new/

https://reviews.llvm.org/D98884