[PATCH] D98278: [test] Add ability to get error messages from CMake for errc substitution
Martin Storsjö via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 19 10:42:21 PDT 2021
mstorsjo added a comment.
In D98278#2637866 <https://reviews.llvm.org/D98278#2637866>, @zero9178 wrote:
> In D98278#2637826 <https://reviews.llvm.org/D98278#2637826>, @mstorsjo wrote:
>
>> Btw, while this change does explain _what_ it does, it doesn't actually say the exact reason _why_. Cleanliness? Sure, that's nice... Or is it a case where e.g. some translations produce different error messages?
>
> Now that you mention it, it's indeed not as clear as I thought. But yes, in the case of MSVCs STL, the messages from `std::error_codes` which are used by various LLVM tools produce different strings then using `strerror` (the C function also called by Python) with the same error codes (Specifically, it has different casing).
Or turning the question another way around: We have a couple different bots that build and run the tests, successfully, with MSVC configurations. Are there tests that failed for you in your configuration, that succeed in the setup of the bots? Or are there other tests that aren't run as part of bots that you're fixing? It's all still very vague to me.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98278/new/
https://reviews.llvm.org/D98278
More information about the llvm-commits
mailing list