[PATCH] D98861: [CMAKE] Fix cross-compilation build

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

Sorry but I'm not satisfied with this direction.

As `LLVM_INCLUDE_TESTS` defaults to enabled, cross builds that used to work without setting any option now hard fail on the configure stage. I might not have intended to actually run the tests, and I never had any need to even think about the `LLVM_INCLUDE_TESTS` option before, as I could just configure and build just fine even if I never intended to build or run the tests.

This change (D98278 <https://reviews.llvm.org/D98278>) was introduced with the explicit motivation that "If the config parameter is not set, or getting the messages failed, due to say a cross compiling configuration without an emulator, it will fall back to using pythons strerror functions.". That behaviour is something I was ok with - and if I would end up running the built tests somehow and 1% of them fail due to missing error texts, that's also ok. But explicitly failing the build, due to a fix intended for one single environment only, is not nice - and if that would have been clear during the review of D98278 <https://reviews.llvm.org/D98278>, I would have spoken up louder at that stage.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98861/new/

https://reviews.llvm.org/D98861