[PATCH] D98958: [NewPM] Disable non-trivial loop-unswitch on targets with divergence

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 19 09:10:44 PDT 2021


rampitec added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/SimpleLoopUnswitch.cpp:2907
+  // unswitching, which is useful for testing and debugging.
+  if ((!NonTrivial || TTI.hasBranchDivergence()) && !EnableNonTrivialUnswitch)
     return false;
----------------
Is this a correct condition? Double negative "!NonTrivial" = Trivial, right? Are we not doing trivial loop unswitching?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98958/new/

https://reviews.llvm.org/D98958



More information about the llvm-commits mailing list