[PATCH] D98957: [NFCI] [TransformUtils] cleanup `CloneFunctionInto`

[Luke Drummond via Phabricator via llvm-commits]

ldrumm created this revision.
ldrumm added reviewers: dexonsmith, nikic, akhuang.
ldrumm added a project: LLVM.
Herald added a subscriber: hiraditya.
ldrumm requested review of this revision.

This function is full of special casing so some readability improvements
help its digestibility:

- Fix an incorrect assert message (after 22a52dfddc <https://reviews.llvm.org/rG22a52dfddcefad4f275eb8ad1cc0e200074c2d8a>)
- Hoist early exit for decl-only function to before analysis over subprogram metadata by DIFinder
- Give an unweildy repeated expression a name
- use ranged `for` basic block iterator
- clang-format


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D98957

Files:
  llvm/lib/Transforms/Utils/CloneFunction.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98957.331894.patch
Type: text/x-patch
Size: 5277 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210319/603cc1fd/attachment.bin>