[PATCH] D98941: [cmake] Enable Clang warnings about redundant semicolons
Aaron Ballman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 19 08:47:57 PDT 2021
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
In D98941#2637120 <https://reviews.llvm.org/D98941#2637120>, @xbolva00 wrote:
> Shouldn’t we rather add that warning to -pedantic in Clang as well?
>
> cc @aaron.ballman @rsmith
I think GCC's behavior is not particularly helpful -- pedantically, the code is correct (in C++11 and later mode).
LGTM with a small tweak!
================
Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:675
+ # pick up on these even in builds with Clang.
+ add_flag_if_supported("-Wc++98-compat-extra-semi" C98_COMPAT_EXTRA_SEMI_FLAG)
endif()
----------------
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98941/new/
https://reviews.llvm.org/D98941
More information about the llvm-commits
mailing list