[PATCH] D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing

[Digger Lin via Phabricator via llvm-commits]

DiggerLin added inline comments.


================
Comment at: llvm/lib/Object/XCOFFObjectFile.cpp:775
+  // A function definition should be a label definition.
+  if (CsectAuxRef.isLabel())
+    return false;
----------------
if we not enable  -ffunction-sections , function entry is label.  


================
Comment at: llvm/lib/Object/XCOFFObjectFile.cpp:815
 
-  // A function definition should be a label definition.
-  if ((CsectAuxEnt->SymbolAlignmentAndType & SymTypeMask) != XCOFF::XTY_LD)
-    return false;
+  auto getSymbolAuxType = [this](uintptr_t AuxAddr) {
+    return viewAs<XCOFF::SymbolAuxType>(
----------------
DiggerLin wrote:
> create  a static function getSymbolAuxType in a file scope maybe  better? 
> All the Aux symbol of 64bit all has the AuxType .  we can use the function for other type too in other place later ?
there already has a function on XCOFFCsectAuxRef ::getAuxType64() 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85774/new/

https://reviews.llvm.org/D85774