[PATCH] D98940: [AMDGPU] Allow index optimisation in SIPreEmitPeephole for bundles

Fri Mar 19 07:33:41 PDT 2021

foad added a comment.

>> See D72737 <https://reviews.llvm.org/D72737> and D91048 <https://reviews.llvm.org/D91048> for the history of that. I'm not saying it's the right place to do it. The point of the current patch is to help us move away from that, i.e. to do less unbundling in SIMemoryLegalizer.
>
> I do not think SIMemoryLegalizer should be doing any unbundling as it is conflating tasks. So will this direction manage to eliminate it?

No, not entirely. D72737 <https://reviews.llvm.org/D72737> added some unbundling (only of bundles containing loads or stores) and D91048 <https://reviews.llvm.org/D91048> added some more (all bundles). The intention here is just to undo the D91048 <https://reviews.llvm.org/D91048> part.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98940/new/

https://reviews.llvm.org/D98940