[PATCH] D98940: [AMDGPU] Allow index optimisation in SIPreEmitPeephole for bundles

Fri Mar 19 07:11:31 PDT 2021

foad added a comment.

In D98940#2637384 <https://reviews.llvm.org/D98940#2637384>, @t-tye wrote:

> In D98940#2637166 <https://reviews.llvm.org/D98940#2637166>, @foad wrote:
>
>>> Currently these are unbundled in SIMemoryLegalizer.
>
> Why is the SIMemoryLegalizer the right place to do the unbundling? Why would the memory SIMemoryLegalizer know that it has "permission" to do that? The SIMemoryLegalizer was intended to do the single job of expanding the atomics semantics.

See D72737 <https://reviews.llvm.org/D72737> and D91048 <https://reviews.llvm.org/D91048> for the history of that. I'm not saying it's the right place to do it. The point of the current patch is to help us move away from that, i.e. to do less unbundling in SIMemoryLegalizer.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98940/new/

https://reviews.llvm.org/D98940