[PATCH] D98646: [DAG] Fold shuffle(bop(shuffle(x,y),shuffle(z,w)),undef) -> bop(shuffle'(x,y),shuffle'(z,w)

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/test/CodeGen/X86/haddsub-shuf.ll:524
 ; AVX1:       # %bb.0:
 ; AVX1-NEXT:    vphaddd %xmm0, %xmm0, %xmm1
 ; AVX1-NEXT:    vextractf128 $1, %ymm0, %xmm0
----------------
pengfei wrote:
> pengfei wrote:
> > Though it's not related to this change, but should it be `vphaddd %xmm1, %xmm1, %xmm1`?
> It's correct. Sorry for the noise.
No worries - thanks for the review!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98646/new/

https://reviews.llvm.org/D98646