[PATCH] D98940: [AMDGPU] Allow index optimisation in SIPreEmitPeephole for bundles

Carl Ritson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 19 05:46:07 PDT 2021


critson marked an inline comment as done.
critson added a comment.

In D98940#2637166 <https://reviews.llvm.org/D98940#2637166>, @foad wrote:

> OK, but really this change should either have its own test, or it should be combined with the change to SIMemoryLegalizer.

I am not against combining this with that change; however, I am still testing that change in case it throws up issues.
Combined with this, the net effect of both changes on lit tests is a single instruction moving (because bundles changed the insertion point of a s_waitcnt).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98940/new/

https://reviews.llvm.org/D98940



More information about the llvm-commits mailing list