[PATCH] D98646: [DAG] Fold shuffle(bop(shuffle(x,y),shuffle(z,w)),undef) -> bop(shuffle'(x,y),shuffle'(z,w)
Pengfei Wang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 19 04:43:20 PDT 2021
- Previous message: [PATCH] D98646: [DAG] Fold shuffle(bop(shuffle(x,y),shuffle(z,w)),undef) -> bop(shuffle'(x,y),shuffle'(z,w)
- Next message: [PATCH] D98646: [DAG] Fold shuffle(bop(shuffle(x,y),shuffle(z,w)),undef) -> bop(shuffle'(x,y),shuffle'(z,w)
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
pengfei accepted this revision.
pengfei added a comment.
This revision is now accepted and ready to land.
I had a check on the tests, the changes should all be correct. LGTM.
================
Comment at: llvm/test/CodeGen/X86/haddsub-shuf.ll:524
; AVX1: # %bb.0:
; AVX1-NEXT: vphaddd %xmm0, %xmm0, %xmm1
; AVX1-NEXT: vextractf128 $1, %ymm0, %xmm0
----------------
Though it's not related to this change, but should it be `vphaddd %xmm1, %xmm1, %xmm1`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98646/new/
https://reviews.llvm.org/D98646
- Previous message: [PATCH] D98646: [DAG] Fold shuffle(bop(shuffle(x,y),shuffle(z,w)),undef) -> bop(shuffle'(x,y),shuffle'(z,w)
- Next message: [PATCH] D98646: [DAG] Fold shuffle(bop(shuffle(x,y),shuffle(z,w)),undef) -> bop(shuffle'(x,y),shuffle'(z,w)
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
More information about the llvm-commits
mailing list