[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR
Paulo Matos via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 19 01:16:18 PDT 2021
pmatos added a comment.
In D95425#2632834 <https://reviews.llvm.org/D95425#2632834>, @lebedev.ri wrote:
> Why are IR-level changes needed if these are generated during lowering?
> Will this play well with typeless pointers?
Are you talking here about the changes in `Codegen/`? Many of the load/store optimizations expect a size for the pointee and when there's none LLVM crashes. All of the changes here is to skip optimizations that wouldn't work on sizeless pointees. I haven't tested this on typeless pointers, but I can say that only the size is checked therefore unless the typeless pointers point to a sizeless pointee, then nothing should change.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95425/new/
https://reviews.llvm.org/D95425
More information about the llvm-commits
mailing list