[PATCH] D98823: [CSSPGO] Add attribute metadata for context profile

[Wenlei He via Phabricator via llvm-commits]

wenlei added inline comments.


================
Comment at: llvm/tools/llvm-profgen/ProfileGenerator.cpp:630
+  return getFunctionProfileForLeafProbe(ContextStrStackCopy, FuncDesc,
+                                        WasLeafInlined);
 }
----------------
hoy wrote:
> wenlei wrote:
> > wenlei wrote:
> > > hoy wrote:
> > > > I'm wondering this should also be done for non-probe CS profile generation.
> > > Yeah, this is a TODO as mentioned in the change description. The change to support that for non-probe profile will actually be bigger since we put everything into flat context string out of unwinder, so wanted to do them separately. Now I left a TODO comment as well, but let me take another look.. 
> > Turns out it can be done easily still, with the help of context key. Updated to support line CS profile too in this change. 
> Thanks for adding the support. Might also need to change existing regression tests if they are failed. 
> 
> Nit: change the description to remove that TODO. Otherwise LGTM.
Tests are all passing, the commit message is updated, but not sure why it wasn't sync to Phabricator. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98823/new/

https://reviews.llvm.org/D98823