[PATCH] D98303: [flang] Update output format test to use GTest

Thu Mar 18 17:14:04 PDT 2021

klausler added a comment.

In D98303#2636054 <https://reviews.llvm.org/D98303#2636054>, @ashermancinelli wrote:

> @klausler D98652 <https://reviews.llvm.org/D98652> hopefully demonstrates that runtime crashes are caught by death tests. This revision has been rebased on D98652 <https://reviews.llvm.org/D98652> - I hope this sufficiently demonstrates that these tests accurately catch crashes. We could also work on another patch that intentionally crashes each of the APIs tested above not already tested in D98652 <https://reviews.llvm.org/D98652>.

I wasn't asking about crashes in the runtime.  I was asking about catching incorrect results and reporting failures.

I will try again.  If you modify the decimal or runtime library in such a way as to cause f18 to emit incorrectly formatted results, does your rewritten test fail?  Let me know when you have confirmed this by observation.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98303/new/

https://reviews.llvm.org/D98303