[PATCH] D97818: [OpenMP] Replace GPU globalization calls with shared memory in the middle-end
Johannes Doerfert via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 18 16:20:53 PDT 2021
jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.
LGTM, one nit.
================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:1031
+ UndefValue::get(Int8ArrTy), CB->getName(), nullptr,
+ GlobalValue::NotThreadLocal, 3);
+
----------------
Can you use a enum here or variable instead of "3".
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97818/new/
https://reviews.llvm.org/D97818
More information about the llvm-commits
mailing list