[PATCH] D98734: [dfsan] Add -dfsan-fast-8-labels flag

[stephan.yichao.zhao via Phabricator via llvm-commits]

stephan.yichao.zhao added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp:2524
+  const unsigned ShadowVecBitSize = ShadowVecSize * DFS.ShadowWidthBits;
+  assert(ShadowVecBitSize <= 128 && "Shadow vector is too large!");
+
----------------
nit: if assert is considered as a nop in an optimized build, ShadowVecBitSize may be considered as a not-used variable. In that case it can be inlined into the assert.


================
Comment at: llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp:19-21
+/// known as taint labels) through a program as it performs computation.
+
+/// There are two possible memory layouts. In the first one, each byte of
----------------
Please add the missing /// at line 20.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98734/new/

https://reviews.llvm.org/D98734