[PATCH] D98851: [OCaml] Add (get/set)_module_identifer functions

Josh Berdine via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 18 14:56:56 PDT 2021


jberdine added inline comments.


================
Comment at: llvm/bindings/ocaml/llvm/llvm_ocaml.c:342
+  const char *Name = LLVMGetModuleIdentifier(M, &Len);
+  return cstr_to_string(Name, (mlsize_t)Len);
+}
----------------
Does this still warn without the cast? I was expecting this cast to be not needed anymore.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98851/new/

https://reviews.llvm.org/D98851



More information about the llvm-commits mailing list