[PATCH] D98733: [fix][Flang][OpenMP] Allow ordered construct within a non-worksharing loop

Kiran Chandramohan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 18 14:47:47 PDT 2021


kiranchandramohan accepted this revision.
kiranchandramohan added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:359-360
+      context_.Say(blkDirective.source,
+          "`ordered` region may not be closely nested inside of "
+          "`critical`, `ordered`, explicit `task` or `taskloop` region."_err_en_US);
+    }
----------------
Nit: I think we should captialise all the regions. Space missing before critical.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98733/new/

https://reviews.llvm.org/D98733



More information about the llvm-commits mailing list