[PATCH] D98426: [llvm-objcopy][Support] move writeToStream helper function to Support.

[Alexey Lapshin via Phabricator via llvm-commits]

avl updated this revision to Diff 331692.
avl added a comment.

addressed comments.

I did not do two changes yet:

- renaming writeToStream into writeToOutput.
- moving writeToStream/writeToOutput into the other file.

It seems to me that writeToStream clearly shows that we write into the stream.
That is true that real writing happens inside Write argument. But there is no any
possibility to write into other output than subclass of raw_ostream. So,
when we call writeToStream we always write into the some stream.

It also seems natural to have writeToStream into the raw_ostream.h/cpp since this
function is for streams which are subclusses of raw_ostream. And all these subclusses
are defined in raw_ostream.h/cpp.

If you still think that above changes(rename writeToStream into writeToOutput, move
writeToStream/writeToOutput into other file) should be done I would do this in next update.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98426/new/

https://reviews.llvm.org/D98426

Files:
  llvm/include/llvm/Support/raw_ostream.h
  llvm/lib/Support/raw_ostream.cpp
  llvm/tools/llvm-objcopy/llvm-objcopy.cpp
  llvm/tools/llvm-objcopy/llvm-objcopy.h
  llvm/unittests/Support/raw_ostream_test.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98426.331692.patch
Type: text/x-patch
Size: 8146 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210318/c427c4b7/attachment.bin>