[PATCH] D98422: [Alias] Add a ah-hoc pattern with two PHI for isKnownNonEqual
JinGu Kang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 18 13:42:13 PDT 2021
jaykang10 added a comment.
In D98422#2635617 <https://reviews.llvm.org/D98422#2635617>, @lebedev.ri wrote:
> I don't understand what the problem here is?
>
> Sure, it's not great that we need to write yet another bicycle,
> but it seems to me that the "only" change `isKnownNonEqual()` needs to support the motivational case
> is to implement a variation of `isAddOfNonZero()` but for multiplications.
@lebedev.ri As you suggested, simply, we could add lots of case by case code with checking AddOfNonZero or MulofNonZeroOrOne or something like that whenever we find different example. However, if we consider more general solution, we could check whether the IV's expression is linear or not. For the general solution, I am asking the SCEV or something like that. If it is not possible to find the general solution, I could try what you suggest.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98422/new/
https://reviews.llvm.org/D98422
More information about the llvm-commits
mailing list