[PATCH] D96628: [VPlan] Add plain text (not DOT's digraph) dumps

Andrei Elovikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 18 12:55:00 PDT 2021


a.elovikov added a comment.

It seems the code wasn't properly guarded before this change, and the proper fix would require changing too many places. I'd prefer to do it in separate patch.

I see two options:

1. "Unguard" the print routines here and commit, work on the cleanup as the next patch.
2. Delay this patch, develop cleanup first, rebase/reland this patch once cleanup is committed. Note that this patch doesn't make things worse - we had all `operator<<` accessible in release builds before it.

I'd prefer to go with the first one, but I can understand if some people would prefer two. What do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96628/new/

https://reviews.llvm.org/D96628



More information about the llvm-commits mailing list