[PATCH] D98718: [AA][NFC] Convert AliasResult to class containing offset for PartialAlias case.

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

In D98718#2632377 <https://reviews.llvm.org/D98718#2632377>, @asbirlea wrote:

> @nikic, could you check this patch through the compiler-tracker, please?

I do see some impact from this patch: https://llvm-compile-time-tracker.com/compare.php?from=be92dcb9f679a23329d360bbc5533acc5f808d9c&to=1f10b8ef5f0243ac0a2679d6f334275471bff316&stat=instructions



================
Comment at: llvm/lib/Analysis/BasicAliasAnalysis.cpp:1582
+    // Cache contains sorted {V1,V2} pairs.
+    Entry.Result.swap(Swapped);
     return Entry.Result;
----------------
Doesn't this swap the cached result? I think the intention here was to only return a swapped result, no?


================
Comment at: llvm/lib/Analysis/BasicAliasAnalysis.cpp:1604
+  // Cache contains sorted {V1,V2} pairs.
+  Entry.Result.swap(Swapped);
   Entry.NumAssumptionUses = -1;
----------------
I think we shouldn't be swapping here, as we computed the result already in swapped order.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98718/new/

https://reviews.llvm.org/D98718