[PATCH] D98762: [LTO][MC] Discard non-prevailing defined symbols in module-level assembly

[Yuanfang Chen via Phabricator via llvm-commits]

ychen added inline comments.


================
Comment at: llvm/lib/LTO/LTO.cpp:832
+  // block.
+  if (!M.getModuleInlineAsm().empty()) {
+    std::string NewIA = ".lto_discard";
----------------
MaskRay wrote:
> If the previous `.lto_discard` directive is not empty, you'll need to reset the list to empty, otherwise can this discard some prevailing symbols?
`NonPrevailingAsmSymbols` is empty initially for each module and the module without inlineasm block is not considered. I think it should be fine?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98762/new/

https://reviews.llvm.org/D98762