[PATCH] D98823: [CSSPGO] Add attribute metadata for context profile

[Wenlei He via Phabricator via llvm-commits]

wenlei added inline comments.


================
Comment at: llvm/tools/llvm-profgen/ProfileGenerator.cpp:630
+  return getFunctionProfileForLeafProbe(ContextStrStackCopy, FuncDesc,
+                                        WasLeafInlined);
 }
----------------
wenlei wrote:
> hoy wrote:
> > I'm wondering this should also be done for non-probe CS profile generation.
> Yeah, this is a TODO as mentioned in the change description. The change to support that for non-probe profile will actually be bigger since we put everything into flat context string out of unwinder, so wanted to do them separately. Now I left a TODO comment as well, but let me take another look.. 
Turns out it can be done easily still, with the help of context key. Updated to support line CS profile too in this change. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98823/new/

https://reviews.llvm.org/D98823