[PATCH] D98736: [SelectionDAG] Don't pass a scalable vector to MachinePointerInfo::getWithOffset in a unit test.

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 18 09:02:43 PDT 2021


sdesmalen added inline comments.


================
Comment at: llvm/unittests/CodeGen/SelectionDAGAddressAnalysisTest.cpp:173
+  SDValue Store0 =
+      DAG->getStore(DAG->getEntryNode(), Loc, Value, Index0, PtrInfo);
   SDValue Store1 = DAG->getStore(DAG->getEntryNode(), Loc, Value, Index1,
----------------
craig.topper wrote:
> Should we get rid of Index0 too?
Yes, I think that makes sense, it makes the test a bit simpler to understand.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98736/new/

https://reviews.llvm.org/D98736



More information about the llvm-commits mailing list